Rewrite trie_by_cid package to be read-write #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roysc
force-pushed
the
roy/v5-dev
branch
9 times, most recently
from
f2118e5 to
8890e2b
Compare
This was referenced May 16, 2023
i-norden
approved these changes
May 18, 2023
There was a problem hiding this comment.
This looks fantastic. Don't have the bandwidth atm to review this line-by-line but nothing jumps out at me after a once-over and the CI provides additional confidence. Do we need to adjust (or re-run) the benchmarks for this?
|
The benchmark code does need to be updated, but this should have a minimal impact. |
* use logrus instead of geth log * remove benchmarks * impl NodeIterator.ParentPath * update go mods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a full copy of
go-ethereum/trie, adapted to pass CIDs instead of hashes. This replaces the read-only implementation we had before, in order to support full EVM operations and root hash computation for cerc-io/ipld-eth-db-validator#26.Also adds CI workflows, resolves #12