Add unit test in Github action CI. #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arijitAD
changed the title
Closed
Closed
arijitAD
force-pushed
the
fix-ci
branch
25 times, most recently
from
2ec7891 to
f655684
Compare
arijitAD
force-pushed
the
fix-ci
branch
16 times, most recently
from
53b5d2c to
600329d
Compare
arijitAD
changed the title
.github/workflows/on-pr.yml
Outdated
|
|
||
| - name: Run unit tests | ||
| run: | ||
| PGPASSWORD=password make statedifftest |
There was a problem hiding this comment.
The password for test db is also in the Makefile. Why do we need it here?
There was a problem hiding this comment.
Added this into Makefile as env.
| platform: [ubuntu-latest] | ||
| runs-on: ${{ matrix.platform }} | ||
| steps: | ||
| - name: Create GOPATH |
There was a problem hiding this comment.
The first three steps here are the same as the earlier job. Can't we factor this out and run the tests in the same folder?
There was a problem hiding this comment.
Yes, We can but then the tests will run sequentially in one job.
Currently, we are running all the tests in parallel hence the setup steps need to be done for each individual test.
There was a problem hiding this comment.
Let me explore this a bit. I think we can parallelize the job after the initial setup.
ashwinphatak
approved these changes
Jun 18, 2021
arijitAD
changed the base branch from
v1.10.3-statediff-0.0.23
to
v1.10.3-statediff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.