Patch for concurrent iterator & others #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace new(trie.Trie) reduce debug noise patch postgres config - add driver, rename DefaultConfig => TestConfig
This allows us to use our alt trie implementation
This was referenced May 16, 2023
i-norden
approved these changes
May 17, 2023
| testBlock1 = types.NewBlock(&header1, nil, nil, nil, new(trie.Trie)) | ||
| testBlock2 = types.NewBlock(&header2, nil, nil, nil, new(trie.Trie)) | ||
| testBlock3 = types.NewBlock(&header3, nil, nil, nil, new(trie.Trie)) | ||
| testBlock1 = types.NewBlock(&header1, nil, nil, nil, trie.NewEmpty(nil)) |
There was a problem hiding this comment.
Nice, thought I had already gotten rid of these,new(trie.Trie) can cause panics on subsequent calls to the trie
There was a problem hiding this comment.
Yeah, this was actually from of a prior commit of yours, that must have gotten lost somewhere in rebase-land
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes a constructor function instead of the actual Trie, so we can use this with the alt Trie implementation,
and adds some other random patches:
new(trie.Trie)DefaultConfig => TestConfig