Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disassociate block number from the indexer object #248

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Disassociate block number from the indexer object #248

merged 2 commits into from
Jun 23, 2022

Conversation

prathamesh0
Copy link
Collaborator

Fixes #245

  • Remove block number field from the indexer struct and instead pass as a function argument wherever required

@prathamesh0 prathamesh0 mentioned this pull request Jun 22, 2022
Closed
i-norden
i-norden approved these changes Jun 22, 2022
View reviewed changes
Copy link
Collaborator

@i-norden i-norden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks for catching this!

@prathamesh0 prathamesh0 changed the title [WIP] Disassociate block number from the indexer object Disassociate block number from the indexer object Jun 22, 2022
@prathamesh0 prathamesh0 self-assigned this Jun 22, 2022
@ashwinphatak ashwinphatak merged commit 5e3de63 into cerc-io:v1.10.19-statediff-v4 Jun 23, 2022
@ashwinphatak ashwinphatak deleted the pm-disassociate-blocknumber branch June 23, 2022 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-norden i-norden i-norden approved these changes

@ashwinphatak ashwinphatak ashwinphatak approved these changes

Assignees

@prathamesh0 prathamesh0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prathamesh0 @ashwinphatak @i-norden