Use prefix comparison for account selective statediffing #247
Conversation
prathamesh0
force-pushed
the
pm-account-selective-statediffing
branch
from
4110c75 to
3fac5fa
Compare
prathamesh0
changed the base branch from
v1.10.18-statediff-v4
to
v1.10.19-statediff-v4
prathamesh0
force-pushed
the
pm-account-selective-statediffing
branch
from
3fac5fa to
365369d
Compare
prathamesh0
force-pushed
the
pm-account-selective-statediffing
branch
from
365369d to
0438809
Compare
prathamesh0
changed the title
There was a problem hiding this comment.
This LGTM! I reviewed the difference iterator a bit and it appears it would be a bit tricky to get it to respect the "descend" flag. Pruning away subtries is much less pertinent for a difference trie than it is when doing a complete trie snapshot but I think it is worth investigating further as a separate issue.
| @@ -322,33 +328,44 @@ func (sdb *StateDiffBuilder) createdAndUpdatedState(a, b trie.NodeIterator, watc | |||
| } | |||
| partialPath := trie.CompactToHex(nodeElements[0].([]byte)) | |||
| valueNodePath := append(node.Path, partialPath...) | |||
|
|
|||
| // ignore leaf node if it is not a watched address | |||
| if !isWatchedAddress(watchedAddressesLeafPaths, valueNodePath) { | |||
There was a problem hiding this comment.
Does the path check on 309 already exclude this possibility?
There was a problem hiding this comment.
It is required since there is an edge case where before a watched contract is deployed, there might be some other account deployed on its path.
Eg. Let's say a leaf node of contract B to be watched has path 0309 when it is deployed at block number 20. Another contract A, which was deployed at block number 15, had leaf node at path 03. If we start statediffing at block number 10 with contract B as the only watched contract, it will index unncessary diff for contract A at block number 15 which just happens to be on the prospective path to contract B.
Created #252 |
Part of #29