Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor builder code to make it reusable #243

Merged

Conversation

prathamesh0
Copy link
Collaborator

@prathamesh0 prathamesh0 requested a review from ashwinphatak June 16, 2022 08:18
@prathamesh0 prathamesh0 self-assigned this Jun 16, 2022
@prathamesh0 prathamesh0 force-pushed the pm-reuse-builder-code branch from a8f6762 to 92c3886 Compare June 16, 2022 08:50
@prathamesh0 prathamesh0 changed the title Changes to reuse builder code in eth-statediff-service Refactor builder code to make it reusable Jun 16, 2022
Copy link
Collaborator

@i-norden i-norden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prathamesh0 prathamesh0 force-pushed the pm-reuse-builder-code branch from 92c3886 to cf24ca8 Compare June 22, 2022 13:31
@prathamesh0 prathamesh0 changed the base branch from v1.10.18-statediff-v4 to v1.10.19-statediff-v4 June 22, 2022 13:32
@prathamesh0 prathamesh0 force-pushed the pm-reuse-builder-code branch from cf24ca8 to df70d03 Compare June 23, 2022 06:00
@ashwinphatak ashwinphatak merged commit c265fdc into cerc-io:v1.10.19-statediff-v4 Jun 23, 2022
@ashwinphatak ashwinphatak deleted the pm-reuse-builder-code branch June 23, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants