Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw/admin: remove unknown user test case from user_bucket_test.go #987

Merged
merged 1 commit into from
May 7, 2024

Conversation

thotz
Copy link
Collaborator

@thotz thotz commented May 7, 2024

Fixes: #984

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.

The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with @Mergifyio rebase to rebase your PR when github indicates that the PR is out of date with the base branch.

@phlogistonjohn phlogistonjohn added the no-API This PR does not include any changes to the public API of a go-ceph package label May 7, 2024
@phlogistonjohn
Copy link
Collaborator

I had to take a look at the conversation in the issue but this change aligns with @anoopcs9 request. Change looks ok to me, but as this is not an API change I would like @anoopcs9 to do the official approving. :-)

Copy link
Collaborator

@ansiwen ansiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of that! LGTM.

@mergify mergify bot merged commit be5dff0 into ceph:master May 7, 2024
16 checks passed
@phlogistonjohn
Copy link
Collaborator

lol. well, it got two approvals anyway :-D

@ansiwen
Copy link
Collaborator

ansiwen commented May 7, 2024

I had to take a look at the conversation in the issue but this change aligns with @anoopcs9 request. Change looks ok to me, but as this is not an API change I would like @anoopcs9 to do the official approving. :-)

Oops, sorry, I reviewed at the same moment. I think this is fine, he also just said "remove it".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestRadosGWTestSuite/TestUserBucket is consistently failing in CI
3 participants