Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: remove features_nautilus.go #980

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

jarrpa
Copy link
Contributor

@jarrpa jarrpa commented Apr 2, 2024

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.

The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with @Mergifyio rebase to rebase your PR when github indicates that the PR is out of date with the base branch.

Signed-off-by: Jose A. Rivera <[email protected]>
@phlogistonjohn phlogistonjohn added the no-API This PR does not include any changes to the public API of a go-ceph package label Apr 2, 2024
@phlogistonjohn
Copy link
Collaborator

I'm setting the 'no-api' label as this only moves code, converging the features.go and features_nautilus.go as there are no pre nautilus build tags any more.

Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@phlogistonjohn
Copy link
Collaborator

I'm going to wait one more day for the ceph main branch to have a build with the mgr fixes. If it's not done by then I think I'll just merge this manually w/o waiting for main to be fixed.

@mergify mergify bot merged commit cfae965 into ceph:master Apr 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants