Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cephfs/admin: Adjust build tags for subvolume quiescing API tests #976

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

anoopcs9
Copy link
Collaborator

With the feature itself getting a backport to upcoming squid release build tags calls for adjustments so that pre-squid and main CI jobs can run the real tests from fs_quiesce_test.go. Until the real squid job is enabled(after ceph squid GA) we could refrain from mentioning squid build tag in those related test files.

With the feature itself getting a backport to upcoming squid release
build tags calls for adjustments so that pre-squid and main CI jobs
can run the real tests from fs_quiesce_test.go. Until the real squid
job is enabled(after ceph squid GA) we could refrain from mentioning
'squid' build tag in those related test files.

Signed-off-by: Anoop C S <[email protected]>
@anoopcs9 anoopcs9 marked this pull request as ready for review March 25, 2024 13:06
@phlogistonjohn phlogistonjohn added the no-API This PR does not include any changes to the public API of a go-ceph package label Mar 25, 2024
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot merged commit 5e9984a into ceph:master Mar 25, 2024
16 checks passed
@anoopcs9 anoopcs9 deleted the build-tags-for-pre-squid branch March 25, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants