Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: prevent warning about redefining _POSIX_C_SOURCE #974

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

nixpanic
Copy link
Member

While building an application with the latest version of go-ceph, the following warning is spit out:

In file included from _cgo_export.c:4:
resize.go:7: warning: "_POSIX_C_SOURCE" redefined
In file included from /usr/include/bits/libc-header-start.h:33,
                 from /usr/include/stdlib.h:26,
                 from _cgo_export.c:3:
/usr/include/features.h:292: note: this is the location of the previous definition
  292 | # define _POSIX_C_SOURCE        200809L

When _POSIX_C_SOURCE is already defined, ther is no need to define it again.

Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@phlogistonjohn phlogistonjohn added the no-API This PR does not include any changes to the public API of a go-ceph package label Mar 21, 2024
@nixpanic
Copy link
Member Author

The failing CI / test-suite (pacific) looks like a flake in an unrelated package. logs

@anoopcs9
Copy link
Collaborator

@Mergifyio rebase

While building an application with the latest version of go-ceph, the
following warning is spit out:

In file included from _cgo_export.c:4:
resize.go:7: warning: "_POSIX_C_SOURCE" redefined
In file included from /usr/include/bits/libc-header-start.h:33,
                 from /usr/include/stdlib.h:26,
                 from _cgo_export.c:3:
/usr/include/features.h:292: note: this is the location of the previous definition
  292 | # define _POSIX_C_SOURCE        200809L

When _POSIX_C_SOURCE is already defined, ther is no need to define it
again.

Signed-off-by: Niels de Vos <[email protected]>
Copy link

mergify bot commented Mar 21, 2024

rebase

✅ Branch has been successfully rebased

@anoopcs9 anoopcs9 force-pushed the rbd/POSIX_C_SOURCE branch from 15099c6 to 35fd02a Compare March 21, 2024 15:55
@mergify mergify bot merged commit 8d71b1f into ceph:master Mar 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants