Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: add a test to verify that encrypted volumes can be resized #973

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

phlogistonjohn
Copy link
Collaborator

Add a test to verify that an encrypted volume can be resized to the desired unencrypted size similar to how the rbd command line tool is documented as able to do.

Fixes: #972

Original-Version-By: Will Gorman

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • n/a Is this a new API? Added a new file that begins with //go:build ceph_preview
  • n/a Ran make api-update to record new APIs

New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.

The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with @Mergifyio rebase to rebase your PR when github indicates that the PR is out of date with the base branch.

@phlogistonjohn phlogistonjohn force-pushed the jjm-rbd-enc-resize-test branch from f3a6556 to 22f7801 Compare March 19, 2024 22:05
@phlogistonjohn phlogistonjohn added the no-API This PR does not include any changes to the public API of a go-ceph package label Mar 19, 2024
rbd/encryption_test.go Outdated Show resolved Hide resolved
Add a test to verify that an encrypted volume can be resized to
the desired unencrypted size similar to how the rbd command line
tool is documented as able to do.

Fixes: ceph#972

Original-Version-By: Will Gorman <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
@phlogistonjohn phlogistonjohn force-pushed the jjm-rbd-enc-resize-test branch from 22f7801 to 64ce772 Compare March 21, 2024 14:20
@phlogistonjohn phlogistonjohn requested a review from anoopcs9 March 21, 2024 14:22
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@mergify mergify bot merged commit bb2a449 into ceph:master Mar 21, 2024
16 checks passed
@phlogistonjohn phlogistonjohn deleted the jjm-rbd-enc-resize-test branch March 21, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should Resize() after EncryptionLoad() account for the encryption header space?
2 participants