Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: add GetSnapGroupNamespace() to get details about group snapshots #968

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

nixpanic
Copy link
Member

@nixpanic nixpanic commented Mar 5, 2024

rbd_snap_get_group_namespace() can be used to get details about
snapshots of an image, that were created as part of a group.

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

@nixpanic nixpanic force-pushed the rbd_snap_get_group_namespace branch from 086a10c to 54e1e41 Compare March 5, 2024 13:42
@nixpanic
Copy link
Member Author

nixpanic commented Mar 5, 2024

The reef CI jobs seem to have infrastructure issues 😞

@phlogistonjohn
Copy link
Collaborator

The reef CI jobs seem to have infrastructure issues 😞

Yes. I've informed the ceph team in the #sepia slack channel. It affects a fairly wide variety of users (both the rpm-reef and debian-reef dirs got removed/renamed) and so I hope it gets resolved soon.

@phlogistonjohn
Copy link
Collaborator

@Mergifyio rebase

Copy link

mergify bot commented Mar 5, 2024

rebase

✅ Branch has been successfully rebased

@phlogistonjohn phlogistonjohn force-pushed the rbd_snap_get_group_namespace branch from 54e1e41 to d8f4825 Compare March 5, 2024 21:52
Copy link

mergify bot commented Mar 5, 2024

rebase

✅ Nothing to do for rebase action

2 similar comments
Copy link

mergify bot commented Mar 5, 2024

rebase

✅ Nothing to do for rebase action

Copy link

mergify bot commented Mar 5, 2024

rebase

✅ Nothing to do for rebase action

phlogistonjohn
phlogistonjohn previously approved these changes Mar 5, 2024
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@phlogistonjohn phlogistonjohn added the API This PR includes a change to the public API of a go-ceph package label Mar 5, 2024
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, see below for a typo.

rbd/snap_group_namespace.go Outdated Show resolved Hide resolved
@nixpanic nixpanic force-pushed the rbd_snap_get_group_namespace branch from d8f4825 to 95dbd39 Compare March 6, 2024 09:54
@nixpanic nixpanic requested a review from anoopcs9 March 6, 2024 09:54
@mergify mergify bot dismissed phlogistonjohn’s stale review March 6, 2024 09:54

Pull request has been modified.

@anoopcs9
Copy link
Collaborator

anoopcs9 commented Mar 6, 2024

@Mergifyio rebase

rbd_snap_get_group_namespace() can be used to get details about
snapshots of an image, that were created as part of a group.

Signed-off-by: Niels de Vos <[email protected]>
Copy link

mergify bot commented Mar 6, 2024

rebase

✅ Branch has been successfully rebased

@anoopcs9 anoopcs9 force-pushed the rbd_snap_get_group_namespace branch from 95dbd39 to 5f2ed05 Compare March 6, 2024 10:34
@anoopcs9 anoopcs9 requested a review from phlogistonjohn March 6, 2024 10:57
@mergify mergify bot merged commit 947b7d3 into ceph:master Mar 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API This PR includes a change to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants