Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw/admin: Add support for user bucket quota #954

Merged
merged 3 commits into from
Feb 6, 2024
Merged

rgw/admin: Add support for user bucket quota #954

merged 3 commits into from
Feb 6, 2024

Conversation

anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Jan 30, 2024 •
edited
Loading

Following APIs have been added to set and get bucket quotas for users.

  • SetBucketQuota
  • GetBucketQuota

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

Credits: Pavel Boev

@anoopcs9 anoopcs9 marked this pull request as ready for review January 30, 2024 09:23
@anoopcs9 anoopcs9 mentioned this pull request Jan 30, 2024
Closed
phlogistonjohn
phlogistonjohn reviewed Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, but RGW is my weakest area. I'll hold off approving so that both thotz and ansiwen can get a chance to review before merging. But if you want my approval at some point, just ping me.

@anoopcs9 anoopcs9 added the API This PR includes a change to the public API of a go-ceph package label Jan 30, 2024
thotz
thotz previously approved these changes Jan 31, 2024
View reviewed changes
@anoopcs9 anoopcs9 force-pushed the add-rgw-user-bucket-quota branch from d481fd6 to f9ad6ba Compare February 2, 2024 12:00
@mergify mergify bot dismissed thotz’s stale review February 2, 2024 12:01

Pull request has been modified.

@anoopcs9 anoopcs9 force-pushed the add-rgw-user-bucket-quota branch from f9ad6ba to 82a34fd Compare February 5, 2024 04:58
@anoopcs9 anoopcs9 requested a review from thotz February 5, 2024 04:58
@anoopcs9
Copy link
Collaborator Author

anoopcs9 commented Feb 6, 2024

But if you want my approval at some point, just ping me.

@phlogistonjohn Now if you may.. 😐

@mergify mergify bot merged commit 0679355 into ceph:master Feb 6, 2024
16 checks passed
@anoopcs9 anoopcs9 deleted the add-rgw-user-bucket-quota branch February 6, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

@thotz thotz thotz approved these changes

@ansiwen ansiwen Awaiting requested review from ansiwen

Assignees
No one assigned
Labels
API This PR includes a change to the public API of a go-ceph package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anoopcs9 @thotz @phlogistonjohn