-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: enable and collect core dumps in tests #941
Conversation
b6cb498
to
ef94272
Compare
cff913a
to
830610d
Compare
This is ready for review |
Question: don't core files usually end up outside the container? Is that why you set the core_pattern in the kernel, to make it drop the cores w/in the container? |
I guess that's not true nowadays anymore. I set the pattern to have a deterministic name I can look for. Different distributions have different defaults. But without it, the core dump also ended in the container (tmp or run directory). Edit: maybe it still would end up outside the container and it only works because this is a bind-mount? Anyway, important is, that is working like this. :-) |
Signed-off-by: Sven Anderson <[email protected]>
830610d
to
fba78e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost looks good to me.
Changes included in the subsequent version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ansiwen not sure if you did it on purpose or not, but there's no label yet so it wont automerge. I'll let you add it in case you did it in order to get >1 review. |
The pr has two approvals, so I added a label myself. ;-) |
This change enables core dumps. If a core dump is created, its backtrace is logged with gdb and it is put into the artifacts together with the test executable.
To see it in action, see #923, which creates a core dump and is based on this PR.