cephfs: made ENOENT a public error #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit renames ErrNoEntry of cephfs to ErrNotExist and making it public allowing other projects to access this. Signed-off-by: Riya Singhal <[email protected]>
ansiwen
added
the
API
|
Technically that is a API change, but our "preview" scheme doesn't support exported constants, so I guess this is fine as it is. WDYT @phlogistonjohn ? |
|
I think it's probably OK to bypass the preview process because a) its backwards compatible and b) there's not much one could want changed during a preview period. |
phlogistonjohn
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit renames ErrNoEntry of cephfs
to ErrNotExist and making it public allowing
other projects to access this.
Signed-off-by: Riya Singhal [email protected]