Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add tests for different Go versions #911

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

ansiwen
Copy link
Collaborator

@ansiwen ansiwen commented Aug 4, 2023

Signed-off-by: Sven Anderson [email protected]

@phlogistonjohn
Copy link
Collaborator

Conceptually, it looks good. I think the test failures are caused by your patch though. In the case of check I think it needs to strip off the "go" prefix from "go1.20.7". I'm not sure why the others are failing but there's something about the generated URL that isn't working properly. But the general gist looks nice. I didn't know you could chain results from one job into the matrix of another. Seems neat!

@ansiwen
Copy link
Collaborator Author

ansiwen commented Aug 4, 2023

I think the test failures are caused by your patch though.

Sure, this is a draft. I'm still playing around.

@ansiwen ansiwen force-pushed the pr/ansiwen/ci-go-versions branch 26 times, most recently from 700c94c to 7cda685 Compare August 5, 2023 00:40
@ansiwen ansiwen marked this pull request as ready for review August 5, 2023 00:41
@ansiwen ansiwen requested a review from phlogistonjohn August 5, 2023 00:44
@ansiwen ansiwen force-pushed the pr/ansiwen/ci-go-versions branch 5 times, most recently from c99b4ff to 9630229 Compare August 5, 2023 15:11
@ansiwen ansiwen force-pushed the pr/ansiwen/ci-go-versions branch from 9630229 to 95d7319 Compare August 5, 2023 15:16
@ansiwen
Copy link
Collaborator Author

ansiwen commented Aug 5, 2023

@phlogistonjohn phlogistonjohn added the no-API This PR does not include any changes to the public API of a go-ceph package label Aug 7, 2023
@mergify mergify bot merged commit 533a0db into master Aug 8, 2023
@mergify mergify bot deleted the pr/ansiwen/ci-go-versions branch August 8, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants