Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGW/admin: add tenant to bucket struct field #898

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

krafZLorG
Copy link
Contributor

RGW/admin: add tenant to bucket struct field

This change adds a new bucket struct field, so we can use rgw.admin.API.GetBucketInfo() to get a bucket's tenant.

$ radosgw-admin bucket stats --bucket "tenant0/qb001"
{
    "bucket": "qb001",
    "num_shards": 11,
    "tenant": "tenant0",

Signed-off-by: Dmitry Kvashnin [email protected]

@anoopcs9 anoopcs9 requested a review from thotz July 8, 2023 13:25
@anoopcs9
Copy link
Collaborator

anoopcs9 commented Jul 10, 2023

Currently we don't verify the returned Bucket struct in corresponding tests? At least in this context shouldn't we add a check to verify newly added Tenant field?

@anoopcs9 anoopcs9 added the API This PR includes a change to the public API of a go-ceph package label Jul 24, 2023
@phlogistonjohn
Copy link
Collaborator

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Aug 2, 2023

rebase

✅ Branch has been successfully rebased

@phlogistonjohn
Copy link
Collaborator

@krafZLorG @anoopcs9 @thotz I'm not clear what the state of this PR is. Do we need changes, reviews, or some other form of attention? I just triggered a rebase but I don't know where to go next with this.

Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krafZLorG Can you consider the suggestion from #898 (comment)

@krafZLorG
Copy link
Contributor Author

There is currently no test for checking the Bucket structure. Why is it a stop factor for adding a missing field? (#704)

Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is currently no test for checking the Bucket structure. Why is it a stop factor for adding a missing field? (#704)

Alright. I tend to agree. I'll wait for others to have a say before final approval.

@phlogistonjohn
Copy link
Collaborator

Changes look OK to me but I'd prefer a 2nd review from a subject matter expert on RGW like @thotz - I don't think we need to require a new test although it would be nice, it could help avoid future regressions.

@phlogistonjohn
Copy link
Collaborator

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Aug 21, 2023

rebase

✅ Branch has been successfully rebased

@anoopcs9
Copy link
Collaborator

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Aug 23, 2023

rebase

✅ Branch has been successfully rebased

@mergify mergify bot merged commit 68fa49b into ceph:master Aug 24, 2023
@phlogistonjohn
Copy link
Collaborator

👍 👍 thanks everyone, for both the contribution and reviews!

@krafZLorG krafZLorG deleted the fix_add_tenant branch August 28, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API This PR includes a change to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants