-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RGW/admin: add tenant to bucket struct field #898
Conversation
Currently we don't verify the returned |
06a4381
to
7d71f46
Compare
@Mergifyio rebase |
✅ Branch has been successfully rebased |
7d71f46
to
3079b00
Compare
@krafZLorG @anoopcs9 @thotz I'm not clear what the state of this PR is. Do we need changes, reviews, or some other form of attention? I just triggered a rebase but I don't know where to go next with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krafZLorG Can you consider the suggestion from #898 (comment)
There is currently no test for checking the Bucket structure. Why is it a stop factor for adding a missing field? (#704) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is currently no test for checking the Bucket structure. Why is it a stop factor for adding a missing field? (#704)
Alright. I tend to agree. I'll wait for others to have a say before final approval.
Changes look OK to me but I'd prefer a 2nd review from a subject matter expert on RGW like @thotz - I don't think we need to require a new test although it would be nice, it could help avoid future regressions. |
@Mergifyio rebase |
✅ Branch has been successfully rebased |
3079b00
to
6fd0ac3
Compare
@Mergifyio rebase |
✅ Branch has been successfully rebased |
6fd0ac3
to
61d605e
Compare
👍 👍 thanks everyone, for both the contribution and reviews! |
RGW/admin: add tenant to bucket struct field
This change adds a new bucket struct field, so we can use rgw.admin.API.GetBucketInfo() to get a bucket's tenant.
Signed-off-by: Dmitry Kvashnin [email protected]