Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove refs to deprecated io/ioutil #896

Merged
merged 4 commits into from
Jul 8, 2023
Merged

chore: remove refs to deprecated io/ioutil #896

merged 4 commits into from
Jul 8, 2023

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Jul 3, 2023

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.

The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with @Mergifyio rebase to rebase your PR when github indicates that the PR is out of date with the base branch.

anoopcs9
anoopcs9 previously approved these changes Jul 3, 2023
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@anoopcs9 anoopcs9 requested a review from phlogistonjohn July 3, 2023 10:15
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for the contribution. Code generally looks good - but here's an optional request: Please break up the change into multiple changes one for each directory and have your "topic" (currently "chore") be named after the subpackage you are changing. For example changes to the ./cephfs/ directory would be named like cephfs: remove refs to deprecated io/ioutil. This helps your changes fit in better with the other changes in the project history.

If you are not comfortable making this change or just prefer not to do it please say so and I can approve. Like I said, it's not required but it would be nice. Thanks!

@testwill
Copy link
Contributor Author

testwill commented Jul 6, 2023

ok, wait

@mergify mergify bot dismissed anoopcs9’s stale review July 8, 2023 05:59

Pull request has been modified.

@anoopcs9
Copy link
Collaborator

anoopcs9 commented Jul 8, 2023

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Jul 8, 2023

rebase

✅ Branch has been successfully rebased

Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks very much for your contribution, I really appreciate it!

@phlogistonjohn phlogistonjohn added the no-API This PR does not include any changes to the public API of a go-ceph package label Jul 8, 2023
@mergify mergify bot merged commit ce4031e into ceph:master Jul 8, 2023
@testwill testwill deleted the ioutil branch July 8, 2023 14:27
@phlogistonjohn
Copy link
Collaborator

Heh, pre-pacific test run was failing (but it was for yum/dnf reasons) but I forgot pre-pacific is not required for mergify. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants