-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove refs to deprecated io/ioutil #896
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, thanks for the contribution. Code generally looks good - but here's an optional request: Please break up the change into multiple changes one for each directory and have your "topic" (currently "chore") be named after the subpackage you are changing. For example changes to the ./cephfs/ directory would be named like cephfs: remove refs to deprecated io/ioutil
. This helps your changes fit in better with the other changes in the project history.
If you are not comfortable making this change or just prefer not to do it please say so and I can approve. Like I said, it's not required but it would be nice. Thanks!
ok, wait |
@Mergifyio rebase |
Signed-off-by: guoguangwu <[email protected]>
Signed-off-by: guoguangwu <[email protected]>
Signed-off-by: guoguangwu <[email protected]>
Signed-off-by: guoguangwu <[email protected]>
✅ Branch has been successfully rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks very much for your contribution, I really appreciate it!
Heh, pre-pacific test run was failing (but it was for yum/dnf reasons) but I forgot pre-pacific is not required for mergify. :-) |
Checklist
//go:build ceph_preview
make api-update
to record new APIsNew or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with
@Mergifyio
rebase
to rebase your PR when github indicates that the PR is out of date with the base branch.