rgw/admin: fix getbucketpolicy api #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoopcs9
requested changes
Jun 2, 2023
thotz
force-pushed
the
fix-owner-struct-in-policy
branch
from
831ae65 to
cf26535
Compare
|
Following diff is shown as the root cause of CI failures: --- rgw/admin/bucket.go.orig
+++ rgw/admin/bucket.go
@@ -78,9 +78,9 @@
} `json:"acl"`
Owner struct {
ID struct {
- ID string `json:"id"`
+ ID string `json:"id"`
Tenant string `json:"tenant"`
- NS string `json:"ns"`
+ NS string `json:"ns"`
} `json:"id"`
DisplayName string `json:"display_name"`
} `json:"owner"` |
thotz
force-pushed
the
fix-owner-struct-in-policy
branch
from
cf26535 to
d3485ac
Compare
anoopcs9
requested changes
Jun 7, 2023
There was a problem hiding this comment.
I realized that we are missing a test for GetBucketPolicy. Can we add a very basic test to bucket_test.go? And while we are at it let's fix the following dead link from LINENO:116:
// GetBucketPolicy - http://docs.ceph.com/docs/mimic/radosgw/adminops/#get-bucket-or-object-policy
d3485ac to
30e4fc2
Compare
thotz
force-pushed
the
fix-owner-struct-in-policy
branch
3 times, most recently
from
dbcd55d to
e2ae172
Compare
anoopcs9
added
the
API
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
anoopcs9
force-pushed
the
fix-owner-struct-in-policy
branch
from
e2ae172 to
0e747f5
Compare
The request header in GetBucketPolicy(), was not passing policy in its header, so the response received Bucket than the actual policy. Signed-off-by: Jiffin Tony Thottan <[email protected]>
thotz
force-pushed
the
fix-owner-struct-in-policy
branch
from
0e747f5 to
19749d2
Compare
thotz
changed the title
phlogistonjohn
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request header in GetBucketPolicy(), was not passing policy in its
header, so the response received Bucket than the actual policy.
fixes #882