Remove useless test file package_test.go #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoopcs9
added
the
no-API
|
I'd suggest that this file is pretty useless and it might be better if we just deleted it rather than moving it. It may have served a good purpose in the early days of the project just to help bootstrap testing but it doesn't assert anything useful so running it doesn't prove much. What do you think? |
I'm all for it. |
anoopcs9
force-pushed
the
run-test-imports-test
branch
from
62148e1 to
99d4eac
Compare
package_test.go merely tested whether package import at the start of source files worked or not which got added in the early days of the project. With the progress made so far this import check is no longer relevant or useful these days. Therefore remove it from the repository. Signed-off-by: Anoop C S <[email protected]>
anoopcs9
changed the title
anoopcs9
force-pushed
the
run-test-imports-test
branch
from
99d4eac to
94b6f8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package_test.go merely tested whether package import at the start of source files worked or not which got added in the early days of the project. With the progress made so far this import check is no longer relevant or useful these days. Therefore remove it from the repository.