Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

micro-osd.sh: Use ipv4 address for mon addr configuration #876

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

anoopcs9
Copy link
Collaborator

mon addr config option expects value in the following format:

< ip-addr >:< port >

Extract host ipv4 address and mention it with default 6789 port as mon addr config option value.

fixes #847

@anoopcs9 anoopcs9 changed the title micro-osd.sh: Use ipv4 address for 'mon addr' configuration micro-osd.sh: Use ipv4 address for mon addr configuration Apr 27, 2023
@anoopcs9 anoopcs9 requested a review from phlogistonjohn April 28, 2023 07:38
@anoopcs9
Copy link
Collaborator Author

I should've figured out the fix earlier but I got confused and messed up my local testing workflow which I managed to discover very lately.

@anoopcs9 anoopcs9 added the no-API This PR does not include any changes to the public API of a go-ceph package label Apr 28, 2023
@phlogistonjohn
Copy link
Collaborator

@Mergifyio rebase

'mon addr' config option expects value in the following format[1]:

<ip-addr>:<port>

Extract host ipv4 address and mention it with default 6789 port as
'mon addr' config option value.

[1] https://docs.ceph.com/en/latest/rados/configuration/mon-config-ref/#minimum-configuration

Signed-off-by: Anoop C S <[email protected]>
@mergify
Copy link

mergify bot commented Apr 28, 2023

rebase

✅ Branch has been successfully rebased

Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

Plus, I learned of getent ahostsv4 for the first time.

@mergify mergify bot merged commit cd007bc into ceph:master Apr 28, 2023
@anoopcs9 anoopcs9 deleted the fix-mon-warning branch April 28, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid mon addr config option warning during execution of ceph-mon
2 participants