-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add some docs on how to find apis #873
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlogistonjohn
added
the
no-API
This PR does not include any changes to the public API of a go-ceph package
label
Apr 24, 2023
@Mergifyio rebase |
✅ Branch has been successfully rebased |
phlogistonjohn
force-pushed
the
jjm-finding-api-doc
branch
from
April 25, 2023 10:26
650d2c1
to
90220ac
Compare
@Mergifyio rebase |
✅ Branch has been successfully rebased |
phlogistonjohn
force-pushed
the
jjm-finding-api-doc
branch
from
May 15, 2023 14:11
90220ac
to
1c905da
Compare
anoopcs9
reviewed
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good generally with minor comments.
phlogistonjohn
force-pushed
the
jjm-finding-api-doc
branch
from
May 18, 2023 13:29
1c905da
to
7511ebc
Compare
Add some prose to the hints doc on how to use our docs convention to map a C/command line api to a go-ceph api. Note how to make use of a {Mon,Mgr}Command API JSON-command without go-ceph code. Note how apis start as preview before becoming stable. Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
force-pushed
the
jjm-finding-api-doc
branch
from
May 18, 2023 13:30
7511ebc
to
c9c8075
Compare
anoopcs9
approved these changes
May 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the informative content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some prose to the hints doc on how to use our docs convention to map a C/command line api to a go-ceph api.
Note how to make use of a {Mon,Mgr}Command API JSON-command without go-ceph code.
Note how apis start as preview before becoming stable.
Fixes: #872 (at least the call for improved docs part)
Checklist
n/a
New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with
@Mergifyio
rebase
to rebase your PR when github indicates that the PR is out of date with the base branch.