Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephfs: Add mknod cephfs API #866

Merged
merged 1 commit into from
Apr 13, 2023
Merged

cephfs: Add mknod cephfs API #866

merged 1 commit into from
Apr 13, 2023

Conversation

Nikhil-Ladha
Copy link
Contributor

Added a new API for the cephfs component named ceph_mknod.

Fixes: #257

Signed-off-by: Nikhil-Ladha [email protected]

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

anoopcs9
anoopcs9 reviewed Apr 13, 2023
View reviewed changes
cephfs/file_ops_test.go Outdated Show resolved Hide resolved
anoopcs9
anoopcs9 previously approved these changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@anoopcs9 anoopcs9 added the API This PR includes a change to the public API of a go-ceph package label Apr 13, 2023
phlogistonjohn
phlogistonjohn requested changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor capitalization consistency issue between this PR and the standard package for unix apis in Go.

cephfs/file_ops.go Outdated Show resolved Hide resolved
@mergify mergify bot dismissed anoopcs9’s stale review April 13, 2023 14:04

Pull request has been modified.

@anoopcs9
Copy link
Collaborator

@Mergifyio rebase

@Nikhil-Ladha @anoopcs9
cephfs: Add mknod cephfs API
54c6c98 
Added a new API for the cephfs component named `ceph_mknod`.

Fixes: ceph#257

Signed-off-by: Nikhil-Ladha <[email protected]>
@mergify
Copy link

mergify bot commented Apr 13, 2023

rebase

✅ Branch has been successfully rebased

@anoopcs9 anoopcs9 force-pushed the issue257/ceph_mknod branch from 0b364fe to 54c6c98 Compare April 13, 2023 14:54
phlogistonjohn
phlogistonjohn approved these changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit bc48ab4 into ceph:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

@anoopcs9 anoopcs9 anoopcs9 approved these changes

Assignees
No one assigned
Labels
API This PR includes a change to the public API of a go-ceph package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing cephfs API components: function ceph_mknod
3 participants
@Nikhil-Ladha @anoopcs9 @phlogistonjohn