Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed few typos #716

Merged
merged 1 commit into from
Jun 27, 2022
Merged

fix: fixed few typos #716

merged 1 commit into from
Jun 27, 2022

Conversation

riya-singhal31
Copy link
Contributor

Signed-off-by: riya-singhal31 [email protected]

Signed-off-by: riya-singhal31 <[email protected]>
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@phlogistonjohn phlogistonjohn added the no-API This PR does not include any changes to the public API of a go-ceph package label Jun 27, 2022
@phlogistonjohn
Copy link
Collaborator

I'm not going to bother with running the CI for this. It's a couple of obviously correct spelling fixes for the docs. :-)

@phlogistonjohn phlogistonjohn merged commit eb651c2 into ceph:master Jun 27, 2022
@phlogistonjohn
Copy link
Collaborator

Oops: I missed one small thing in my eagerness to merge this. But I'll not it for the next time you contribute to go-ceph: The commit message should take the form "[topic]: [short description]" where the topic is the functional area that you worked on (oft derived from the name of the directory). So in this case the proper topic would have been "doc", not "fix". It's no biggie anyway I just overlooked it and then figured I'd mention it for posterity :-)

@riya-singhal31
Copy link
Contributor Author

Oops: I missed one small thing in my eagerness to merge this. But I'll not it for the next time you contribute to go-ceph: The commit message should take the form "[topic]: [short description]" where the topic is the functional area that you worked on (oft derived from the name of the directory). So in this case the proper topic would have been "doc", not "fix". It's no biggie anyway I just overlooked it and then figured I'd mention it for posterity :-)

Thanks for letting me know this. Will take care of this from now on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants