implements: a public function's type must be exported too #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlogistonjohn
added
the
no-API
4 tasks
ansiwen
reviewed
Apr 26, 2022
ansiwen
approved these changes
Apr 28, 2022
Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
force-pushed
the
jjm-implements-exported
branch
from
8e7ab1f to
51696ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implements API checker should not treat a function as exported if it's type is not exported.
Certain APIs, such as those pertaining to JSON require public methods on unexported types. Since the type is not exported
implementsshould not worry about it.