-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] workaround recent changes in ceph's CI built container images #1051
Conversation
Anoop's PR #1043 fixes CI failures for the non pre-/main jobs. However, the ci builds are now removing yum repo files and lack CEPH_VERSION environment variable. I'm discussing these with the ceph team members but in the very short term I wanted to see the CI run successfully. In addition to the continer changes we needed to deal with a recent cephfs fallocate change getting backported (but not released) to various ceph branches. I took the "big hammer" appraoch and just disabled it in more cases than strictly needed. |
cc @ansiwen for discussion on 2024-12-12. |
🎉 All dependencies have been resolved ! |
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
9a0e5e2
to
8d839a8
Compare
Recent changes to the ceph ci images are removing the repo files, as well as some other minor changes. We're working with ceph maintainers to come up with a clean solution for all, but in the meantime re-installing the ceph-release rpm recreates the file we need to continue. Signed-off-by: John Mulligan <[email protected]>
In pr#1045 we disabled the test for main. It seems that the change has now been backported to many other branches as the test began failing on all pre-{quincy,reef,squid} cli jobs too. Disable the test for pretty much all the active ceph branches. Signed-off-by: John Mulligan <[email protected]>
Our test code uses CEPH_VERSION but (at least for now) the quay.ceph.io ci container no longer sets that environment variable. Signed-off-by: John Mulligan <[email protected]>
8d839a8
to
30466ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for fixing the CI.
Oh..the commit message for 098a730 is bit misleading when it says that pre-{quincy,reef,squid} jobs were failing due to changes backported to those branches. I noticed it after adding the |
Experimental workaround for ceph ci container build changes.
Depends on #1043
Checklist
//go:build ceph_preview
make api-update
to record new APIsNew or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with
@Mergifyio
rebase
to rebase your PR when github indicates that the PR is out of date with the base branch.