cephfs: Adjust with the fallocate API changes #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There has been an internal change with fallocate API[1] forcing us not to run those fallocate tests which uses mode as 0. For now we skip those tests on main branch. [1] ceph/ceph#59725 Signed-off-by: Anoop C S <[email protected]>
There are backports created for fallocate API changes[1] that got merged recently. Considering the time taken for these backports to get in to release branches and finally as a released version we create a separate test file to have more fine grained control over various pre-release CI jobs with the help of corresponding build tags. Modification of build tags should go hand-in-hand with the version detection logic used in file_test.go once a backport is available in released version. [1] ceph/ceph#59725 Signed-off-by: Anoop C S <[email protected]>
anoopcs9
force-pushed
the
fix-fallocate-mode-zero-tests
branch
from
401f5db to
9e922f1
Compare
|
I see that the PR is unlabeled so far. If you're OK with only my review feel fre to put the |
anoopcs9
added
the
no-API
Ah, I seem to forget that from time to time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent behavioural changes w.r.t fallocate API calls for corresponding changes in our tests which uses mode 0. In addition to skipping those existing tests we try to cover up the time taken for backports to land in released versions causing CI failures in our pre-release jobs. This has been implemented by creating a new test file intended to be controlled and maintained using required build tags. The new test file can be removed once all the expected backports are available with released versions.
fixes #1044