You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoopcs9
added
extended-review
A submitter or reviewer feels the PR needs an extended review period
no-API
This PR does not include any changes to the public API of a go-ceph package
labels
Sep 13, 2024
Do we already use non-POSIX extensions elsewhere? Then I guess this shouldn't hurt. Otherwise the former approach is probably more portable. Not sure about Darwin+clang, if it emulates the GNU stuff.
Do we already use non-POSIX extensions elsewhere? Then I guess this shouldn't hurt. Otherwise the former approach is probably more portable.
cephfs defines it but rbd explicitly undefines it. Provided that this change is internal I think we can use it and whoever(packages) doesn't want can undefine as we saw with rbd.
Not sure about Darwin+clang, if it emulates the GNU stuff.
man dlsym(3) says the following:
. . .
The _GNU_SOURCE feature test macro must be defined in order to obtain
the definitions of RTLD_DEFAULT and RTLD_NEXT from <dlfcn.h>.
. . .
Signed-off-by: Anoop C S <[email protected]>
no-APIThis PR does not include any changes to the public API of a go-ceph package
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
anoopcs9
force-pushed
the
gnu-source-rtld-default
branch
from
man dlsym(3) says the following: