rbd: implement librbd.rbd_group_snap_get_info #1025
Conversation
nixpanic
force-pushed
the
rbd/rbd_group_snap_get_info
branch
2 times, most recently
from
a40229f to
dee055a
Compare
phlogistonjohn
added
the
API
|
@Mergifyio rebase |
anoopcs9
force-pushed
the
rbd/rbd_group_snap_get_info
branch
from
dee055a to
5d6c6f6
Compare
✅ Branch has been successfully rebased |
|
|
|
nixpanic
force-pushed
the
rbd/rbd_group_snap_get_info
branch
from
5d6c6f6 to
2052bb5
Compare
mergify
bot
dismissed
anoopcs9’s stale review
Pull request has been modified.
nixpanic
force-pushed
the
rbd/rbd_group_snap_get_info
branch
2 times, most recently
from
e604719 to
f7fa0ce
Compare
|
|
1 similar comment
|
|
|
@Mergifyio rebase |
The new GroupSnapGetInfo function can be used to get a list of the RBD image snapshots that were created as part of the RBD group snapshot. Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
✅ Branch has been successfully rebased |
phlogistonjohn
force-pushed
the
rbd/rbd_group_snap_get_info
branch
from
f7fa0ce to
4b0b8c8
Compare
|
|
|
|
|
All dependencies are merged, this should be ready for review (again) now. |
|
@Mergifyio refresh Maybe that is needed to detect the merging of the dependencies? |
✅ Pull request refreshed |
|
@Mergifyio rebase |
✅ Nothing to do for rebase action |
|
@ansiwen could you please have a look at this? |
|
@Mergifyio rebase |
✅ Nothing to do for rebase action |
| // Types and constants are copied from librbd.h with added "_" as prefix. This | ||
| // prevents redefinition of the types on librbd versions that have them | ||
| // already. | ||
|
|
||
| typedef enum { | ||
| _RBD_GROUP_SNAP_NAMESPACE_TYPE_USER = 0 | ||
| } _rbd_group_snap_namespace_type_t; | ||
|
|
||
| typedef struct { | ||
| char *image_name; | ||
| int64_t pool_id; | ||
| uint64_t snap_id; | ||
| } _rbd_group_image_snap_info_t; | ||
|
|
||
| typedef struct { | ||
| char *id; | ||
| char *name; | ||
| char *image_snap_name; | ||
| rbd_group_snap_state_t state; | ||
| _rbd_group_snap_namespace_type_t namespace_type; | ||
| size_t image_snaps_count; | ||
| _rbd_group_image_snap_info_t *image_snaps; | ||
| } _rbd_group_snap_info2_t; | ||
|
|
||
| // rbd_group_snap_get_info_fn matches the rbd_group_snap_get_info function signature. | ||
| typedef int(*rbd_group_snap_get_info_fn)(rados_ioctx_t group_p, | ||
| const char *group_name, | ||
| const char *snap_name, | ||
| _rbd_group_snap_info2_t *snaps); | ||
|
|
||
| // rbd_group_snap_get_info_dlsym take *fn as rbd_group_snap_get_info_fn and | ||
| // calls the dynamically loaded rbd_group_snap_get_info function passed as 1st | ||
| // argument. | ||
| static inline int rbd_group_snap_get_info_dlsym(void *fn, | ||
| rados_ioctx_t group_p, | ||
| const char *group_name, | ||
| const char *snap_name, | ||
| _rbd_group_snap_info2_t *snaps) { | ||
| // cast function pointer fn to rbd_group_snap_get_info and call the function | ||
| return ((rbd_group_snap_get_info_fn) fn)(group_p, group_name, snap_name, snaps); | ||
| } | ||
|
|
||
| // rbd_group_snap_get_info_cleanup_fn matches the rbd_group_snap_get_info_cleanup function signature. | ||
| typedef int(*rbd_group_snap_get_info_cleanup_fn)(_rbd_group_snap_info2_t *snaps); | ||
|
|
||
| // rbd_group_snap_get_info_cleanup_dlsym take *fn as rbd_group_snap_get_info_cleanup_fn and | ||
| // calls the dynamically loaded rbd_group_snap_get_info_cleanup function passed as 1st | ||
| // argument. | ||
| static inline int rbd_group_snap_get_info_cleanup_dlsym(void *fn, | ||
| _rbd_group_snap_info2_t *snaps) { | ||
| // cast function pointer fn to rbd_group_snap_get_info_cleanup and call the function | ||
| return ((rbd_group_snap_get_info_cleanup_fn) fn)(snaps); | ||
| } |
There was a problem hiding this comment.
I wish we could avoid some of that boilerplate... But I don't have a suggestion right now, how to improve it. So I guess we just keep it like that for now, which probably means forever. 😅
|
@Mergifyio rebase |
✅ Nothing to do for rebase action |
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 08e5b62 |
|
Ha..just because we had the following depends in the PR description and ceph did not have it configured, merging got stalled.
Now I can fool Mergify by adding the above lines back. |
|
|
1 similar comment
|
|
The new GroupSnapGetInfo function can be used to get a list of the RBD
image snapshots that were created as part of the RBD group snapshot.
This feature is implemented in 2 steps:
dlsymI hope that makes it easier to understand, and might help others contributing such dynamically loaded functions too.
Depends-on: ceph/ceph#59883
Depends-on: ceph/ceph#59959
Checklist
//go:build ceph_previewmake api-updateto record new APIs