Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: Remove invalid snap ID test skip #1021

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Aug 19, 2024

Fix for https://tracker.ceph.com/issues/47287 is now available with quincy and above releases. Therefore do not skip GetSnapTimestamp API test for an invalid snap ID.

fixes #440

depends on ceph v17.2.8 GA.

@phlogistonjohn
Copy link
Collaborator

One example failure, FWIW:

# github.com/ceph/go-ceph/rbd [github.com/ceph/go-ceph/rbd.test]
rbd/snapshot_test.go:21:18: undefined: os
rbd/snapshot_test.go:23:3: undefined: serverVersion
rbd/snapshot_test.go:158:10: undefined: serverVersion

@anoopcs9 anoopcs9 force-pushed the rm-getsnaptimestamp-test-skip branch 2 times, most recently from 19e53f4 to 7c24797 Compare August 19, 2024 15:46
@anoopcs9
Copy link
Collaborator Author

Quincy backport is pending a release and thus CI job failed with SIGABRT for test-suite (quincy). I can see that ceph/ceph#55473 is already merged for v17.2.8 milestone.

@anoopcs9 anoopcs9 added the no-API This PR does not include any changes to the public API of a go-ceph package label Aug 20, 2024
@anoopcs9 anoopcs9 force-pushed the rm-getsnaptimestamp-test-skip branch 2 times, most recently from a7ec27a to d21b1c3 Compare September 4, 2024 05:40
@anoopcs9 anoopcs9 marked this pull request as ready for review September 4, 2024 15:29
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phlogistonjohn
Copy link
Collaborator

@Mergifyio rebase

Copy link

mergify bot commented Sep 25, 2024

rebase

✅ Branch has been successfully rebased

@phlogistonjohn phlogistonjohn force-pushed the rm-getsnaptimestamp-test-skip branch from d21b1c3 to cb576b8 Compare September 25, 2024 14:23
@phlogistonjohn
Copy link
Collaborator

@Mergifyio rebase

Copy link

mergify bot commented Oct 10, 2024

rebase

✅ Branch has been successfully rebased

@phlogistonjohn phlogistonjohn force-pushed the rm-getsnaptimestamp-test-skip branch from cb576b8 to 905902d Compare October 10, 2024 17:48
@phlogistonjohn
Copy link
Collaborator

@Mergifyio rebase

@phlogistonjohn phlogistonjohn force-pushed the rm-getsnaptimestamp-test-skip branch from 905902d to 2a1ca2d Compare October 28, 2024 14:03
Copy link

mergify bot commented Oct 28, 2024

rebase

✅ Branch has been successfully rebased

@anoopcs9
Copy link
Collaborator Author

@Mergifyio rebase

Fix for https://tracker.ceph.com/issues/47287 is now available with
quincy and above releases. Therefore do not skip GetSnapTimestamp
API test for an invalid snap ID.

Signed-off-by: Anoop C S <[email protected]>
Copy link

mergify bot commented Nov 26, 2024

rebase

✅ Branch has been successfully rebased

@anoopcs9 anoopcs9 force-pushed the rm-getsnaptimestamp-test-skip branch from 2a1ca2d to 5b83f69 Compare November 26, 2024 14:31
@anoopcs9
Copy link
Collaborator Author

phew..finally 😓 .

@mergify mergify bot merged commit 19165ed into ceph:master Nov 26, 2024
16 checks passed
@anoopcs9 anoopcs9 deleted the rm-getsnaptimestamp-test-skip branch November 26, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rbd: remove test skips for non-existing snap ID issue (test audit)
2 participants