Add new rados/striper package #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like rados_striper_stat2 isn't that old. I guess that's why I made this PR a draft first ;-) |
phlogistonjohn
force-pushed
the
jjm-rados-striper
branch
from
9f83185 to
ec66fbc
Compare
phlogistonjohn
changed the title
anoopcs9
added
the
API
anoopcs9
requested changes
Aug 2, 2024
anoopcs9
reviewed
Aug 2, 2024
Reorganize the RUN command in the Dockerfile that sets up distro based repositories and ceph packages. Move the `&&` to the beginning of the lines to highlight when commands begin (and end). Change the indent level of items that are arguments to commands to further clarify what is part of what. Signed-off-by: John Mulligan <[email protected]>
Add libradosstriper devel and debug packages to the test container image. This is in preparation for adding a future `rados/striper` package to go-ceph that will wrap these APIs. Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
force-pushed
the
jjm-rados-striper
branch
2 times, most recently
from
a127aef to
9f3bea0
Compare
ansiwen
reviewed
Aug 7, 2024
There was a problem hiding this comment.
I only have one comment, but will not insist on it.
Otherwise I'm not sure I understand the striping concept here. Isn't it more like a bundle? What happens if you make the striped object smaller? Does the number of underlying objects change? Anyway, that is not related to this PR.
Maybe they're using the terms poorly, but AFAIK it just writes segments of the "virtual object" across many objects in rados. Any other questions, I think you'd have to ask the ceph team :-) |
Start a new `rados/striper` package that wraps Ceph's libradosstriper. The libradosstriper library builds on top of the librados library to support striping large "objects" over multiple RADOS objects. Fixes: ceph#1011 Signed-off-by: John Mulligan <[email protected]>
Add support for xattr APIs to the Striper object. Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
Add a package doc comment that also points out some things I learned about how `rados` command line tool lists striped objects to preempt being asked later on. :-) Signed-off-by: John Mulligan <[email protected]>
Add rados/striper to the implements tool. It needs to be recognized as a new C-API wrapping library. Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
force-pushed
the
jjm-rados-striper
branch
from
9f3bea0 to
6fa0723
Compare
anoopcs9
approved these changes
Aug 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
rados/striperpackage that wraps Ceph's libradosstriper. The libradosstriper library builds on top of the librados library to support striping large "objects" over multiple RADOS objects.Fixes: #1011
Checklist
//go:build ceph_previewmake api-updateto record new APIsNew or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with
@Mergifyiorebaseto rebase your PR when github indicates that the PR is out of date with the base branch.