Makefile: Use ?= for initial variable definitions(part 2)
#1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoopcs9
force-pushed
the
make-save-custom-vars
branch
from
4c80d0f to
3d2d03d
Compare
anoopcs9
changed the title
?= for initial variable definitions
anoopcs9
force-pushed
the
make-save-custom-vars
branch
from
3d2d03d to
c4ab29a
Compare
anoopcs9
changed the title
?= for initial variable definitions?= for initial variable definitions(part 2)
anoopcs9
force-pushed
the
make-save-custom-vars
branch
from
c4ab29a to
1d52b55
Compare
|
I don't use the environment this heavily for make, but OK. |
phlogistonjohn
added
the
no-API
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
anoopcs9
force-pushed
the
make-save-custom-vars
branch
from
1d52b55 to
e8d48f6
Compare
:= is not capable of accepting values(for variables) from execution environment. Therefore replace := with ?= for completeness. Signed-off-by: Anoop C S <[email protected]>
anoopcs9
force-pushed
the
make-save-custom-vars
branch
from
e8d48f6 to
438e213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iteration #2 of #725.
CEPH_IMGandCEPH_TAGare commonly used to include custom ceph images as base while building go-ceph container images for testing and development purposes.