ci: install Helm with script located on GitHub #3843
Conversation
| @@ -34,6 +34,9 @@ SNAPSHOT_VERSION=v6.1.0 | |||
| #TEST_COVERAGE=html | |||
| #GO_COVER_DIR=_output/ | |||
|
|
|||
| # URL for the script to install Helm | |||
| HELM_SCRIPT=https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | |||
There was a problem hiding this comment.
Using script from main branch is risky, possible to use latest released version?
There was a problem hiding this comment.
This is what is recommended in the documentation. I expect that the previous URL pointed to the same version.
There was a problem hiding this comment.
Also note that it is only used for installing. The version pointed to by HELM_VERSION will be installed and used.
There was a problem hiding this comment.
If there is a bug in script we will.b3 easily affected as its from main branch, let's handle it in different PR
There was a problem hiding this comment.
I do not think that is needed. Hopefully their main branch is at least as stable as our devel branch.
nixpanic
added
ci/skip/multi-arch-build
|
/test ci/centos/k8s-e2e-external-storage/1.24 |
|
/test ci/centos/k8s-e2e-external-storage/1.25 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.24 |
|
/test ci/centos/mini-e2e-helm/k8s-1.25 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.24 |
|
/test ci/centos/mini-e2e/k8s-1.25 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
|
/retest ci/centos/mini-e2e-helm/k8s-1.26 |
Failed to install packages from the CentOS build system: |
|
/retest ci/centos/mini-e2e/k8s-1.26 |
|
Installing Helm fails often in the CI. The Helm documentation does not point to `https://git.io/get_helm.sh` anymore, but to a location on GitHub. To make it easier to update the location in the future, it has now been added to `build.env`, just like the `HELM_VERSION`. See-also: https://helm.sh/docs/intro/install/ Signed-off-by: Niels de Vos <[email protected]>
|
/test ci/centos/k8s-e2e-external-storage/1.24 |
|
/test ci/centos/k8s-e2e-external-storage/1.25 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.24 |
|
/test ci/centos/mini-e2e-helm/k8s-1.25 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.24 |
|
/test ci/centos/mini-e2e/k8s-1.25 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
|
/retest ci/centos/mini-e2e/k8s-1.24 |
Again failed with |
|
Added the backport label, it is a harmless change, and with that we can test the label copier. |
@nixpanic are we hitting any bug as we hit it twice or is some issue with e2e itself? |
|
@Mergifyio requeue |
☑️ This pull request is already queued |
Oh, maybe the test did not get restarted? Or I checked the wrong logs? It is running now, so I assume it was my mistake. |
Installing Helm fails often in the CI. The Helm documentation does not point to
https://git.io/get_helm.shanymore, but to a location on GitHub. To make it easier to update the location in the future, it has now been added tobuild.env, just like theHELM_VERSION.See-also: https://helm.sh/docs/intro/install/
The failures in CI jobs would look like this:
Installing
golangci-lintsucceeds, the nextcurlcommand fails.Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any testprogress or results