Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: fix the pre-commit-golang repo link #3761

Merged
merged 1 commit into from
Apr 20, 2023
Merged

cleanup: fix the pre-commit-golang repo link #3761

merged 1 commit into from
Apr 20, 2023

Conversation

karthik-us
Copy link
Collaborator

@karthik-us karthik-us commented Apr 19, 2023 •
edited by nixpanic
Loading

Initialization of pre-commit-golang environment is failing when using the git://github.com/dnephin/pre-commit-golang repo link. Changing it to https://github.com/dnephin/pre-commit-golang fixed the issue.

Depends-on: #3762
Fixes: #3760

@mergify mergify bot added bug Something isn't working cleanup labels Apr 19, 2023
@karthik-us
Copy link
Collaborator Author

cc @Madhu-1

@nixpanic nixpanic added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures labels Apr 20, 2023
@nixpanic nixpanic requested a review from a team April 20, 2023 07:40
@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Apr 20, 2023
@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.23

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.24

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.25

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.26

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.23

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.25

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.26

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.23

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.25

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.26

@github-actions
Copy link

/test ci/centos/upgrade-tests-cephfs

@github-actions
Copy link

/test ci/centos/upgrade-tests-rbd

@github-actions github-actions bot removed the ok-to-test Label to trigger E2E tests label Apr 20, 2023
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 20, 2023

CI is failing, Looks like there is an update in linter tools as we use the latest. Need a separate PR or a commit to fix it

@nixpanic
Copy link
Member

@Mergifyio rebase

@karthik-us @nixpanic
cleanup: fix the pre-commit-golang repo link
103adae 
Initialization of pre-commit-golang environment is failing when
using the git://github.com/dnephin/pre-commit-golang repo link.
Changing it to https://github.com/dnephin/pre-commit-golang
fixed the issue.

Signed-off-by: karthik-us <[email protected]>
Fixes: ceph#3760
@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2023

rebase

✅ Branch has been successfully rebased

@nixpanic nixpanic force-pushed the fix-golang-pre-commit branch from 8b657e0 to 103adae Compare April 20, 2023 15:28
@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Apr 20, 2023
@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.23

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.24

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.25

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.26

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.23

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.25

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.26

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.23

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.25

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.26

@github-actions
Copy link

/test ci/centos/upgrade-tests-cephfs

@github-actions
Copy link

/test ci/centos/upgrade-tests-rbd

@github-actions github-actions bot removed the ok-to-test Label to trigger E2E tests label Apr 20, 2023
@mergify mergify bot merged commit ecbac21 into ceph:devel Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riya-singhal31 riya-singhal31 riya-singhal31 approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to initialize environment for pre-commit-golang
4 participants
@karthik-us @Madhu-1 @nixpanic @riya-singhal31