-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add httpx tracing extension #1098
Conversation
@lzchen can we get your help with that PR? Our project and other people could benefit greatly from it 🙏 |
inirudebwoy try rebase on the latest |
@inirudebwoy |
@inirudebwoy |
7f8f75e
to
10f3d4e
Compare
@lzchen Applied your recommendations. Tests are passing. Is there anything else you think needs to be changed? |
Looks good. Thanks for the contribution. Looks like builds are still failing for py27 and p35. Are those versions supported for httpx? |
10f3d4e
to
4c779bc
Compare
@lzchen No they are not. httpx supports Python 3.7+. I have updated |
Our unit test builds for python versioning is a bit complex right now due to some packages not supporting the older python versions. For now you can modify the commands in
That should make the builds pass. |
4c779bc
to
409968b
Compare
@lzchen thanks. Done that now. |
409968b
to
3e6c426
Compare
@lzchen do you have any ETA when you will publish this extension? |
Hi 😄
I have been missing
httpx
https://www.python-httpx.org package extension so I create one.Thankfully
httpx
is very similar torequests
so most of my code is actually taken fromrequests
extension.If this is a problem I can address it somehow 😄