Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add httpx tracing extension #1098

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

inirudebwoy
Copy link
Contributor

Hi 😄
I have been missing httpx https://www.python-httpx.org package extension so I create one.
Thankfully httpx is very similar to requests so most of my code is actually taken from requests extension.
If this is a problem I can address it somehow 😄

@macieyng
Copy link

@lzchen can we get your help with that PR? Our project and other people could benefit greatly from it 🙏

@TobKed
Copy link

TobKed commented Dec 29, 2022

inirudebwoy try rebase on the latest master. Maybe it will help fix CI.

@TobKed
Copy link

TobKed commented Jan 3, 2023

@lzchen
Copy link
Contributor

lzchen commented Jan 9, 2023

@inirudebwoy
Could you add a README.rst file? Please make sure to include an example of how to use this in code.

@lzchen
Copy link
Contributor

lzchen commented Jan 9, 2023

@inirudebwoy
Thanks for the contribution and apologies for the long delay before the review. The changes look good to me. I've left a few comments. Could you also rebase to the latest master commit, fix the failing builds and update some of the version dependencies

@inirudebwoy inirudebwoy force-pushed the httpx-ext branch 3 times, most recently from 7f8f75e to 10f3d4e Compare January 11, 2023 21:50
@inirudebwoy
Copy link
Contributor Author

@lzchen Applied your recommendations. Tests are passing. Is there anything else you think needs to be changed?

@lzchen
Copy link
Contributor

lzchen commented Jan 12, 2023

@inirudebwoy

Looks good. Thanks for the contribution. Looks like builds are still failing for py27 and p35. Are those versions supported for httpx?

@inirudebwoy
Copy link
Contributor Author

@lzchen No they are not. httpx supports Python 3.7+. I have updated setup.py and (hopefully) tox.ini.

@lzchen
Copy link
Contributor

lzchen commented Jan 12, 2023

Our unit test builds for python versioning is a bit complex right now due to some packages not supporting the older python versions. For now you can modify the commands in tox.ini like this:

py3{7,8,9}-unit: {[constants]unit-base-command}
py36-unit: {[constants]unit-base-command} --ignore=contrib/opencensus-ext-httpx
py{27,34,35}-unit: {[constants]unit-base-command} --ignore=contrib/opencensus-ext-stackdriver --ignore=contrib/opencensus-ext-flask --ignore=contrib/opencensus-ext-httpx

That should make the builds pass.

@inirudebwoy
Copy link
Contributor Author

@lzchen thanks. Done that now.

@lzchen lzchen merged commit 642df18 into census-instrumentation:master Jan 13, 2023
@miqm
Copy link

miqm commented Jan 16, 2023

@lzchen do you have any ETA when you will publish this extension?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants