Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the tests for Patternal #50

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve the tests for Patternal #50

wants to merge 3 commits into from
+167 −19

Conversation

aalex
Copy link
Collaborator

@aalex aalex commented Dec 13, 2024

No description provided.

@aalex aalex self-assigned this Dec 13, 2024
@aalex
Copy link
Collaborator Author

aalex commented Dec 13, 2024

There are two potential bugs:

  • (Patternal) The note off should not be output right away.
  • (get_quantification_date) The timestamp (position) that is returned is negative

@aalex aalex marked this pull request as ready for review December 16, 2024 16:13
@aalex aalex requested a review from jcelerier December 16, 2024 16:13
@aalex aalex changed the title (draft) Improve the tests for Patternal Improve the tests for Patternal Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcelerier jcelerier Awaiting requested review from jcelerier

Assignees

@aalex aalex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aalex