-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ed25519 precompile #2177
Conversation
Coverage from tests in coverage: 50.8% of statements across all listed packagescoverage: 63.2% of statements in consensus/istanbul coverage: 42.7% of statements in consensus/istanbul/announce coverage: 55.8% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 65.2% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2177 +/- ##
==========================================
+ Coverage 55.16% 55.24% +0.08%
==========================================
Files 676 676
Lines 114015 114015
==========================================
+ Hits 62895 62989 +94
+ Misses 47242 47177 -65
+ Partials 3878 3849 -29
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the minimal change to keep the diff as small as possible so directly before the release. The implementation can be removed in a PR after the hardfork.
Description
Remove the CIP-25 as part of the CIP: celo-org/celo-proposals#392
Backwards compatibility
Part of the Gingerbread P2 Hard Fork