Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ed25519 precompile #2177

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

gastonponti
Copy link
Contributor

Description

Remove the CIP-25 as part of the CIP: celo-org/celo-proposals#392

Backwards compatibility

Part of the Gingerbread P2 Hard Fork

@github-actions
Copy link

github-actions bot commented Aug 16, 2023

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 0404e7a

coverage: 50.8% of statements across all listed packages
coverage:  63.2% of statements in consensus/istanbul
coverage:  42.7% of statements in consensus/istanbul/announce
coverage:  55.8% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  65.2% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

@github-actions
Copy link

github-actions bot commented Aug 16, 2023

5854 passed, 1 failed, 45 skipped

Test failures:
  TestEthersJSCompatibilityDisableAfterGingerbread: e2e_test
Checking getExchangeSpenders. spenders = [0x000000000000000000000000000000000000d028]
Checking medianRate. numerator = 1000000000000000000000000 denominator = 1000000000000000000000000
Checking gas price minimum. cusdValue = 100000000
Checking getExchangeSpenders. spenders = [0x000000000000000000000000000000000000d028]
Checking medianRate. numerator = 1000000000000000000000000 denominator = 1000000000000000000000000
Checking gas price minimum. cusdValue = 100000000
e2e_test.go:742:
e2e_test.go:744:
This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.08% 🎉

Comparison is base (1c5df77) 55.16% compared to head (520158f) 55.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2177      +/-   ##
==========================================
+ Coverage   55.16%   55.24%   +0.08%     
==========================================
  Files         676      676              
  Lines      114015   114015              
==========================================
+ Hits        62895    62989      +94     
+ Misses      47242    47177      -65     
+ Partials     3878     3849      -29     
Files Changed Coverage Δ
core/vm/contracts.go 80.65% <ø> (ø)

... and 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@karlb karlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the minimal change to keep the diff as small as possible so directly before the release. The implementation can be removed in a PR after the hardfork.

@gastonponti gastonponti merged commit 0404e7a into master Aug 16, 2023
@gastonponti gastonponti deleted the gastonponti/remove-ed25519-precompile branch August 16, 2023 19:24
gastonponti added a commit that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants