Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove precompiles (Gingerbread P2) #2168

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

gastonponti
Copy link
Contributor

@gastonponti gastonponti commented Aug 2, 2023

Description

Removal of the

  • bls12377 precompiles
  • bls13381 precompiles
  • cip20 precompile
    as part of the CIP-XX to be closer to Ethereum

Backwards compatibility

Part of the Gingerbread P2 Hard Fork

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

5855 passed, 45 skipped

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 45.45% and project coverage change: -0.82% ⚠️

Comparison is base (b77d52a) 56.00% compared to head (b61438b) 55.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2168      +/-   ##
==========================================
- Coverage   56.00%   55.18%   -0.82%     
==========================================
  Files         666      676      +10     
  Lines      112237   114015    +1778     
==========================================
+ Hits        62855    62922      +67     
- Misses      45524    47218    +1694     
- Partials     3858     3875      +17     
Files Changed Coverage Δ
core/vm/evm.go 13.91% <0.00%> (-0.10%) ⬇️
core/vm/contracts.go 80.65% <62.50%> (-0.18%) ⬇️

... and 41 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 1c5df77

coverage: 45.7% of statements across all listed packages
coverage:  57.2% of statements in consensus/istanbul
coverage:  23.7% of statements in consensus/istanbul/announce
coverage:  54.3% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  60.7% of statements in consensus/istanbul/core
coverage:  45.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

@gastonponti gastonponti force-pushed the gastonponti/remove-bls12377-precompiles branch from 2b1dcbe to 2dc38bf Compare August 11, 2023 22:06
@gastonponti gastonponti changed the title Remove bls12377 precompiles (Gingerbread) Remove precompiles (Gingerbread P2) Aug 11, 2023
@palango
Copy link
Contributor

palango commented Aug 14, 2023

@gastonponti You can probably remove the whole TestPrecompileWrappers now.

@socket-security
Copy link

socket-security bot commented Aug 15, 2023

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

@palango palango force-pushed the gastonponti/remove-bls12377-precompiles branch from 8e84371 to b61438b Compare August 15, 2023 07:58
@gastonponti gastonponti merged commit 1c5df77 into master Aug 15, 2023
@gastonponti gastonponti deleted the gastonponti/remove-bls12377-precompiles branch August 15, 2023 18:09
gastonponti added a commit that referenced this pull request Aug 22, 2023
* Remove bls12377 precompiles

* Remove bls12381 precompiles

* Remove CIP20 precompile

---------

Co-authored-by: Paul Lange <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants