CIP 54: Don't send community rewards to reserve #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage from tests in coverage: 50.0% of statements across all listed packagescoverage: 63.4% of statements in consensus/istanbul coverage: 42.7% of statements in consensus/istanbul/announce coverage: 55.7% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 63.2% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/randomCommentID: c8bcbb8128 |
palango
force-pushed
the
paul/epoch-rewards-reserve
branch
from
cd0fb9a to
d47d76c
Compare
|
Coverage from tests in coverage: 49.2% of statements across all listed packagescoverage: 61.3% of statements in consensus/istanbul coverage: 37.5% of statements in consensus/istanbul/announce coverage: 54.4% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 64.6% of statements in consensus/istanbul/core coverage: 45.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
|
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2030 +/- ##
==========================================
+ Coverage 54.30% 55.34% +1.04%
==========================================
Files 692 674 -18
Lines 115642 113454 -2188
==========================================
- Hits 62795 62792 -3
+ Misses 49014 46843 -2171
+ Partials 3833 3819 -14
☔ View full report in Codecov by Sentry. |
palango
changed the title
palango
force-pushed
the
paul/epoch-rewards-reserve
branch
from
d47d76c to
2685a67
Compare
carterqw2
approved these changes
Jun 6, 2023
palango
force-pushed
the
paul/epoch-rewards-reserve
branch
from
2685a67 to
ab302ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Required changes to implement CIP 54
Tested
TODO
Related issues
Fixes https://github.com/celo-org/celo-blockchain-planning/issues/22
Backwards compatibility
Changes consensus rules and will therefor be enabled with the next hardfork.