-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub CI check for Markdownlint #948
Conversation
Codecov Report
@@ Coverage Diff @@
## main #948 +/- ##
==========================================
+ Coverage 58.26% 58.50% +0.24%
==========================================
Files 129 129
Lines 7727 7727
==========================================
+ Hits 4502 4521 +19
+ Misses 2754 2735 -19
Partials 471 471
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one rebase pls @rootulp 🙏🏻
…stiaorg#911) * refactor: extract HeaderGetter interface from daser into header pkg * refactor: delete interface.go file from das pkg * refactor: Store interface wraps getter methods * chore: rebase fixes * feat: add `/verified_balance` endpoint * chore: lint * refactor: dedup handleBalanceRequest * docs: update state ADR * refactor: consolidate verified_balance and balance endpoints --> verify balance by default * chore: replace TODOs with PR refs * refactor: apply john review comments * refactor: extract sdk error func into helpers file, rename import aliases * doc: update ADR header.Store -> header.Getter
@Wondertan @renaynay this PR is ready to be merged. May I request write access to this repo so that I can merge it / future approved PRs? |
Resolves #947