#145: Cleanup TCP configurations across platforms and unified defaults into one dict #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
==========================================
+ Coverage 91.6% 91.84% +0.23%
==========================================
Files 14 14
Lines 1668 1668
Branches 232 235 +3
==========================================
+ Hits 1528 1532 +4
+ Misses 111 108 -3
+ Partials 29 28 -1
Continue to review full report at Codecov.
|
|
I don't believe the above errors are due to my code changes. |
auvipy
reviewed
Sep 20, 2017
|
I've added some tests around this. Once again - I don't think I'm responsible for failing tests. |
|
Are there any other requirements to be fulfilled before this can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is meant to fix #145 , but also goes further to refactor the default TCP settings which were scattered in different places throughout the code. Now, TCP settings are clearly defined within platform.py, and the correct TCP settings are declared here by moving the KNOWN_TCP_OPTS. There are no longer HAS_TCP_* settings which led to fairly confusing code.
#145 was caused by WSL not supporting the majority of TCP platforms, but Python's socket library making them available because it thinks it's a standard Linux platform.