Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google-cloud-pubsub requirement from <=2.20.3,>=2.18.4 to >=2.18.4,<=2.25.2 #2171

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 22, 2024

Updates the requirements on google-cloud-pubsub to permit the latest version.

Release notes

Sourced from google-cloud-pubsub's releases.

v2.25.2

2.25.2 (2024-09-30)

Documentation

  • Add command line args for OpenTelemetry Subscribe sample (#1265) (0ff7f2a)
Changelog

Sourced from google-cloud-pubsub's changelog.

2.25.2 (2024-09-30)

Documentation

  • Add command line args for OpenTelemetry Subscribe sample (#1265) (0ff7f2a)

2.25.1 (2024-09-29)

Bug Fixes

  • Update the requirements.txt for samples directory (#1263) (5cce8b1)

2.25.0 (2024-09-28)

Features

2.24.0 (2024-09-24)

Features

Bug Fixes

2.23.1 (2024-09-09)

Bug Fixes

  • Replace asserts with None checks for graceful shutdown (#1244) (ced4f52)

2.23.0 (2024-07-29)

Features

  • Add max messages batching for Cloud Storage subscriptions (#1224) (91c89d3)

2.22.0 (2024-07-06)

... (truncated)

Commits

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
google-cloud-pubsub [>= 2.26.a, < 2.27]

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [google-cloud-pubsub](https://github.com/googleapis/python-pubsub) to permit the latest version.
- [Release notes](https://github.com/googleapis/python-pubsub/releases)
- [Changelog](https://github.com/googleapis/python-pubsub/blob/main/CHANGELOG.md)
- [Commits](googleapis/python-pubsub@v2.18.4...v2.25.2)

---
updated-dependencies:
- dependency-name: google-cloud-pubsub
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Oct 22, 2024
Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haimjether our CI fully passes with the new versions, but we blocked it here per the error you described.

Can you maybe create a test that fails on this issue please?
It’s confusing that a PR is fully passing but we can’t go on, so I want to have the CI blocking these upgrades automatically. Also, if a new version fixes the error somehow, we’ll know it to allow the upgrade to move on.

@auvipy FYI, same story

@haimjether
Copy link
Contributor

Will do - makes sense 👌

@Nusnus
Copy link
Member

Nusnus commented Oct 22, 2024

Will do - makes sense 👌

Awesome! Thank you!

@haimjether
Copy link
Contributor

@Nusnus ,
TL;DR
created a test + a proper fix in #2175 .

The longer version:
The issue appears to be in protobuf version - a package google-cloud-pubsub depends on.
So the fix is restriction of this culprit + remove restriction of the original google-cloud-pubsub + test to validate this compatibility.

@Nusnus
Copy link
Member

Nusnus commented Oct 23, 2024

@dependabot recreate

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 23, 2024

Looks like google-cloud-pubsub is no longer updatable, so this is no longer needed.

@dependabot dependabot bot closed this Oct 23, 2024
@dependabot dependabot bot deleted the dependabot/pip/google-cloud-pubsub-gte-2.18.4-and-lte-2.25.2 branch October 23, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants