-
-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.13 #2052
Conversation
faefbe1
to
d031fb7
Compare
d26e891
to
d14fa66
Compare
I fixed some merge conflicts, lets see how the integration test for python 3.13 works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be resolved before merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ERROR t/integration/test_kafka.py::test_KafkaBasicFunctionality::test_connect - NameError: name 'KafkaException' is not defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applying some changes, let’s see how the CI reacts
@auvipy I’ve converted it back to Draft as the CI is not ready for merge at the moment. |
I am also having issues with pytest-celery: celery/pytest-celery#420 Celery itself did pass the Python 3.13 CI though: celery/celery#9309 |
ce0b18b
to
d99d5f6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2052 +/- ##
=======================================
Coverage 81.48% 81.48%
=======================================
Files 77 77
Lines 9507 9507
Branches 1148 1148
=======================================
Hits 7747 7747
Misses 1569 1569
Partials 191 191 ☔ View full report in Codecov by Sentry. |
d99d5f6
to
6f708c7
Compare
It looks like Google Cloud monitoring library (https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-monitoring) does not support Python 3.13:
See: https://github.com/celery/kombu/actions/runs/11343305734/job/31545591989?pr=2052#step:7:1141 |
6f708c7
to
109ef1d
Compare
109ef1d
to
e08d430
Compare
e08d430
to
a14bc3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a feeling my last rebase would pass due to a recent dep update.
This is finally over, thanks everyone!
Fixes #2051.