-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds versatility to Rayonix XTC class #723
Conversation
dermen
commented
Apr 4, 2024
- defaults for detz_offset and cent_mm were calibrated using mfxl032222 (April 2024)
* defaults for detz_offset and cent_mm were calibrated using mfxl032222 (April 2024)
Thanks @dermen. Going from nonsense defaults to calibrated ones seems reasonable. It will make running the image viewer on .loc files give more sensible numbers. Should we put in the help for these parameters that that these numbers will likely drift? Every time the sample delivery system is changed at MFX these numbers would change. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #723 +/- ##
==========================================
- Coverage 42.23% 42.20% -0.03%
==========================================
Files 187 187
Lines 16752 16762 +10
Branches 3193 3194 +1
==========================================
Hits 7075 7075
- Misses 9031 9041 +10
Partials 646 646 |
@phyy-nx , think we can move this in ? |
Righto, thanks. One thing to consider is re-writing this bit of the xfel gui to use these new parameters instead of writing them to the phil file: |
Defaults for detz_offset and cent_mm were calibrated using mfxl032222 (April 2024)