Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds versatility to Rayonix XTC class #723

Merged
merged 5 commits into from
Apr 8, 2024
Merged

adds versatility to Rayonix XTC class #723

merged 5 commits into from
Apr 8, 2024

Conversation

dermen
Copy link

@dermen dermen commented Apr 4, 2024

  • defaults for detz_offset and cent_mm were calibrated using mfxl032222 (April 2024)

dermen added 3 commits April 4, 2024 08:43
* defaults for detz_offset and cent_mm were calibrated using mfxl032222 (April 2024)
@dermen dermen requested review from phyy-nx and irisdyoung April 4, 2024 15:50
@phyy-nx
Copy link
Contributor

phyy-nx commented Apr 4, 2024

Thanks @dermen. Going from nonsense defaults to calibrated ones seems reasonable. It will make running the image viewer on .loc files give more sensible numbers.

Should we put in the help for these parameters that that these numbers will likely drift? Every time the sample delivery system is changed at MFX these numbers would change.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 42.20%. Comparing base (6818056) to head (248b3e4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
- Coverage   42.23%   42.20%   -0.03%     
==========================================
  Files         187      187              
  Lines       16752    16762      +10     
  Branches     3193     3194       +1     
==========================================
  Hits         7075     7075              
- Misses       9031     9041      +10     
  Partials      646      646              

@dermen
Copy link
Author

dermen commented Apr 8, 2024

@phyy-nx , think we can move this in ?

@phyy-nx
Copy link
Contributor

phyy-nx commented Apr 8, 2024

Righto, thanks. One thing to consider is re-writing this bit of the xfel gui to use these new parameters instead of writing them to the phil file:
https://github.com/cctbx/cctbx_project/blob/master/xfel/ui/db/job.py#L347-L355

@phyy-nx phyy-nx merged commit bb93372 into main Apr 8, 2024
20 checks passed
@phyy-nx phyy-nx deleted the xtcrayonix branch April 8, 2024 22:55
toastisme pushed a commit to toastisme/dxtbx that referenced this pull request Jul 18, 2024
Defaults for detz_offset and cent_mm were calibrated using mfxl032222 (April 2024)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants