Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade CI Node.js version to 20 #26

Merged
merged 3 commits into from
Oct 5, 2024

Conversation

ali-shokoohi
Copy link
Contributor

@ali-shokoohi ali-shokoohi commented Oct 5, 2024

Fix: #25

Added a new step to setup the Node version to "20.8.1" and Also specified Ubuntu version to prevent same version conflicts in the future

Changes:

  • Added setup Node version step in ".github/workflows/ci.yml" file to use Node version "20.8.1"
  • Specified Ubuntu version in "runs-on" steps

ali-shokoohi and others added 3 commits October 5, 2024 11:11
Added a new step to setup the Node version to "20.8.1".

Changes:
- Added setup Node version step in ".github/workflows/ci.yml" file to use Node version "20.8.1"
Changes:
- Specified Ubuntu version in "runs-on" steps
@ali-shokoohi
Copy link
Contributor Author

@hsluoyz Using the latest version of Ubuntu may cause version conflicts in the future.

@hsluoyz hsluoyz changed the title feat: fix ci node engine version feat: upgrade CI Node.js version to 20 Oct 5, 2024
@hsluoyz
Copy link
Member

hsluoyz commented Oct 5, 2024

never mind, we follow this behavior across the org. Hard coding it to 22.04 also brings trouble for unavailability of that old OS in future.

@hsluoyz hsluoyz merged commit 0747ebe into casbin:master Oct 5, 2024
4 checks passed
Copy link

github-actions bot commented Oct 5, 2024

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants