feat: Add option to check takeUntil within all angular entities #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've had a quick look at this and it LGTM. I'll review it tomorrow. Thanks. |
cartant
reviewed
May 9, 2020
There was a problem hiding this comment.
This looks good. Thanks.
I do have one small suggestion: could you rename checkAllClasses to checkDecorators and have it accept an array of decorator names?
"checkDecorators": ["Component"] // The default, if the option isn't specified
"checkDecorators": ["All"] // Match/check all of the decorators in your PR
"checkDecorators": ["Component", "Pipe"] // Match/check only these
IMO, this would better represent how checked classes are matched and would potentially avoid confusion that could arise from @Injectable not strictly being required.
…ssary to check class
|
4.32.0 should be published now. |
|
Thanks for review and help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to check takeUntil within services, directives, pipes and components
Services, directives and pipes may also contain subscriptions to unsubscribe from when they are destroyed. They also can implement OnDestroy
This is especially important in case of microfrontend when several apps can be bootstraped and destroyed while page lifetime