Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"rxjs-no-unsafe-scope" false positve #101

Closed
dmytro-gokun opened this issue Jun 19, 2019 · 5 comments
Closed

"rxjs-no-unsafe-scope" false positve #101

dmytro-gokun opened this issue Jun 19, 2019 · 5 comments

Comments

@dmytro-gokun
Copy link

"rxjs-no-unsafe-scope" produces a false positive for the following piece of code:

platformBrowserDynamic()
    .bootstrapModule(AppModule)
    .catch(err => console.log(`ERROR CAUGHT: ${err}`)); // <=== HERE

What is interesting to note is that "bootstrapModule" returns a Promise, not Observable. So, i do not expect "rxjs-tslint-rules" to kick in here at all.

@cartant
Copy link
Owner

cartant commented Jun 19, 2019

So, i do not expect "rxjs-tslint-rules" to kick in here at all.

See #56

@cartant
Copy link
Owner

cartant commented Jun 19, 2019

Regarding #56, I don't plan on prioritising that issue at all. I have other projects - that will be more beneficial for RxJS developers - that need my time. I can add console to the whitelist, but I don't anticipate looking at #56 anytime soon.

You might want to take that into consideration when weighing up whether or not you want - or even really need - this rule.

@dmytro-gokun
Copy link
Author

@cartant Okay, i get you. So, is it fair to say that this project will phase out (perhaps, in favor of eslint or something else)?

@cartant
Copy link
Owner

cartant commented Jun 19, 2019

This project will be around for the foreseeable future, but perhaps not this rule. If it continues to effect bugs, I will likely deprecate and delete it. There are other, more useful, rules in this package than the unsafe scope rule.

@dmytro-gokun
Copy link
Author

Gotcha. Thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants