feat(rxjs-no-subject-unsubscribe): Add rule.

README.md

@@ -8,7 +8,7 @@
 
 ### What is it?
 
-`rxjs-tslint-rules` is small set of TSLint rules to help manage projects that use `rxjs/add/...` imports.
+`rxjs-tslint-rules` is small set of TSLint rules to help manage projects that use `rxjs/add/...` imports and to highlight other potential problems.
 
 ### Why might I need it?
 
@@ -24,7 +24,7 @@ TypeScript will see the merged declarations in all modules, making it difficult
 
 This can cause problems, as whether or not `Observable` is patched then depends upon the order in which the modules are executed.
 
-The rules in this package can be used to highlight missing - or unused - imports.
+The rules in this package can be used to highlight missing - or unused - imports and other potential problems with RxJS.
 
 ## Install
 
@@ -54,6 +54,7 @@ The package includes the following rules:
 | --- | --- | --- |
 | `rxjs-add` | Enforces the importation of patched observables and operators used in the module. | See below |
 | `rxjs-no-add` | Disallows the importation of patched observables and operators. | None |
+| `rxjs-no-subject-unsubscribe` | Disallows the calling of `unsubscribe` directly upon `Subject` instances. For an explanation of why this can be a problem, see [this](https://stackoverflow.com/a/45112125/6680611) Stack Overflow answer. | None |
 | `rxjs-no-unused-add` | Disallows the importation of patched observables or operators that are not used in the module. | None |
 | `rxjs-prefer-add` | Disallows the importation of `rxjs` or `rxjs/Rx`. | None |
 

fixtures/async-subject-with-unsubscribe/fixture.ts

@@ -0,0 +1,4 @@
+import { AsyncSubject } from "rxjs/AsyncSubject";
+
+const subject = new AsyncSubject<number>();
+subject.unsubscribe();

fixtures/async-subject-with-unsubscribe/tsconfig.json

@@ -0,0 +1,13 @@
+{
+  "compilerOptions": {
+    "baseUrl": ".",
+    "lib": ["es2015"],
+    "noEmit": true,
+    "paths": {
+      "rxjs": ["../node_modules/rxjs"]
+    },
+    "skipLibCheck": true,
+    "target": "es5"
+  },
+  "include": ["fixture.ts"]
+}

fixtures/async-subject-with-unsubscribe/tslint.json

@@ -0,0 +1,8 @@
+{
+  "defaultSeverity": "error",
+  "jsRules": {},
+  "rules": {
+    "rxjs-no-subject-unsubscribe": { "severity": "error" }
+  },
+  "rulesDirectory": "../../build/rules"
+}

fixtures/subject-with-unsubscribe/fixture.ts

@@ -0,0 +1,4 @@
+import { Subject } from "rxjs/Subject";
+
+const subject = new Subject<number>();
+subject.unsubscribe();

fixtures/subject-with-unsubscribe/tsconfig.json

@@ -0,0 +1,13 @@
+{
+  "compilerOptions": {
+    "baseUrl": ".",
+    "lib": ["es2015"],
+    "noEmit": true,
+    "paths": {
+      "rxjs": ["../node_modules/rxjs"]
+    },
+    "skipLibCheck": true,
+    "target": "es5"
+  },
+  "include": ["fixture.ts"]
+}

fixtures/subject-with-unsubscribe/tslint.json

@@ -0,0 +1,8 @@
+{
+  "defaultSeverity": "error",
+  "jsRules": {},
+  "rules": {
+    "rxjs-no-subject-unsubscribe": { "severity": "error" }
+  },
+  "rulesDirectory": "../../build/rules"
+}

fixtures/subject-without-unsubscribe/fixture.ts

@@ -0,0 +1,5 @@
+import { Subject } from "rxjs/Subject";
+
+const subject = new Subject<number>();
+const subscription = subject.subscribe();
+subscription.unsubscribe();

fixtures/subject-without-unsubscribe/tsconfig.json

@@ -0,0 +1,13 @@
+{
+  "compilerOptions": {
+    "baseUrl": ".",
+    "lib": ["es2015"],
+    "noEmit": true,
+    "paths": {
+      "rxjs": ["../node_modules/rxjs"]
+    },
+    "skipLibCheck": true,
+    "target": "es5"
+  },
+  "include": ["fixture.ts"]
+}

fixtures/subject-without-unsubscribe/tslint.json

@@ -0,0 +1,8 @@
+{
+  "defaultSeverity": "error",
+  "jsRules": {},
+  "rules": {
+    "rxjs-no-subject-unsubscribe": { "severity": "error" }
+  },
+  "rulesDirectory": "../../build/rules"
+}