Skip to content

Commit

Permalink
test(nested): Add failing false positive.
Browse files Browse the repository at this point in the history
  • Loading branch information
cartant committed Apr 20, 2019
1 parent 3c683a4 commit 6630f3f
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"test": "yarn run lint && yarn run test:build && yarn run test:mocha && yarn run test:tslint-v5 && yarn run test:tslint-v6 && yarn run test:tslint-v6-compat",
"test:build": "yarn run test:clean && tsc -p tsconfig.json",
"test:clean": "rimraf build",
"test:debug": "tslint --test ./test/v6/fixtures/no-ignored-subscription/**/tslint.json",
"test:debug": "tslint --test ./test/v6/fixtures/no-nested-subscribe/prototype/tslint.json",
"test:issues": "yarn run test:clean && tsc -p tsconfig.json && tslint --test ./test/v6/fixtures/issues/**/tslint.json",
"test:mocha": "mocha build/**/*-spec.js",
"test:tslint-v5": "yarn --cwd ./test/v5 install && yarn --cwd ./test/v5 upgrade && tslint --test ./test/v5/fixtures/**/tslint.json",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import { Observable } from "rxjs";

const observableSubscribe = Observable.prototype.subscribe;
expect(Observable.prototype.subscribe).to.equal(observableSubscribe);

[no-nested-subscribe]: Nested subscribe calls are forbidden
13 changes: 13 additions & 0 deletions test/v6/fixtures/no-nested-subscribe/prototype/tsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"compilerOptions": {
"baseUrl": ".",
"lib": ["es2015"],
"noEmit": true,
"paths": {
"rxjs": ["../../node_modules/rxjs"]
},
"skipLibCheck": true,
"target": "es5"
},
"include": ["fixture.ts"]
}
8 changes: 8 additions & 0 deletions test/v6/fixtures/no-nested-subscribe/prototype/tslint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"defaultSeverity": "error",
"jsRules": {},
"rules": {
"rxjs-no-nested-subscribe": { "severity": "error" }
},
"rulesDirectory": "../../../../../build/rules"
}

0 comments on commit 6630f3f

Please sign in to comment.