-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Identify subjects] Doesn't work with BehaviorSubject, EtcSubject #88
Comments
Works in the tests I just added: eslint-plugin-rxjs/tests/rules/suffix-subjects.ts Lines 585 to 603 in 695b783
Also, this is not valid, as class MySuperSubject extends Subject {} |
what about test suffix is "$$", when I have |
The |
Same config, including "$$" suffix const destroy$: Subject<void> = new Subject<void>(); // eslint error
const obj = {
destroy$: new Subject<void>(), // eslint error
}
function fn(destroy$: Subject<void>) {} // eslint error
export class OrderListComponent {
private destroy: Subject<void> = new Subject<void>(); // eslint error
private destroy$: Subject<void> = new Subject<void>(); // no eslint error <---
} |
@cotneit Should be fixed in 5.0.2. In future, please open a new issue instead of commenting on a closed issue. You can reference the closed issue from the new issue. In general, that's something you should do for all repos - not just this one. It's easy to overlook such comments. |
@cartant Thank you! Appreciate the advice, will do so in the future! |
The text was updated successfully, but these errors were encountered: